Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task for VAT validation #4 #7363

Merged
merged 4 commits into from
Jul 23, 2021
Merged

Add task for VAT validation #4 #7363

merged 4 commits into from
Jul 23, 2021

Conversation

rsasch
Copy link

@rsasch rsasch commented Jul 22, 2021

Closes https://github.com/broadinstitute/dsp-spec-ops/issues/367 by translating this English into a SQL query:

If a vid has a null transcript, then the vid is only in one row of the VAT.

@kcibul kcibul self-requested a review July 22, 2021 15:21
kcibul
kcibul approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsasch rsasch merged commit 8d440b3 into ah_var_store Jul 23, 2021
@rsasch rsasch deleted the rsa_add_vat_val_4 branch July 23, 2021 00:50
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcibul kcibul kcibul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsasch @kcibul