#259 Inline schema for importgenomes.wdl #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcibul
approved these changes
Mar 30, 2021
| File metadata_schema | ||
| String? pet_schema | ||
| String? vet_schema | ||
| String? metadata_schema |
There was a problem hiding this comment.
I believe you can just do this with
String? metadata_schema = "sample_name:STRING,sample_id:INTEGER,interval_list_blob:STRING,inferred_state:STRING"
it's a little more straightforward, less variables/code... but please verify it works :D should also work for the other schemas
There was a problem hiding this comment.
you also then wouldn't need to change all the "metadata_schema" to "metadata_inline_schema" below
kcibul
approved these changes
Mar 30, 2021
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* inline schemas * inline schema testing * remove new lines in strings for schema def * formatting of if else values * replace dockstore yml to original * reorganize where default values are to workflow input block
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.