Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in ExtractCohortEngine #7168

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix bug in ExtractCohortEngine #7168

merged 1 commit into from
Mar 30, 2021

Conversation

mmorgantaylor
Copy link
Member

when extracting more than one sample using ExtractCohort, multi-allelic sites get written with bad formatting for the AS_YNG field:
AC=2,1;AF=0.028,0.014;AN=72;AS_QD=.;AS_VQSLOD=-6.7307,.;AS_YNG=[G, .];ExcessHet=0.0927;FS=0.000;SOR=0.693

this PR processes the AS_YNG field properly, resulting in properly formatted AS_YNG fields:
AC=2,1;AF=0.028,0.014;AN=72;AS_QD=.;AS_VQSLOD=-6.7307,.;AS_YNG=G,.;ExcessHet=0.0927;FS=0.000;SOR=0.693

@gatk-bot
Copy link

gatk-bot commented Mar 29, 2021

Travis reported job failures from build 33394
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud openjdk11 33394.14 logs
cloud openjdk8 33394.1 logs
cloud openjdk11 33394.14 logs
cloud openjdk8 33394.1 logs

Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

@mmorgantaylor mmorgantaylor merged commit bfebd6b into ah_var_store Mar 30, 2021
@mmorgantaylor mmorgantaylor deleted the mmt_fix_ec_bug branch March 30, 2021 14:13
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants