Enable Read/Execution Project for BQ Queries #7136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericsong can you confirm this works for your use case? |
Marianie-Simeon
approved these changes
Mar 9, 2021
|
works! |
|
Eric confirmed this works! |
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* use project id for query operation for samples * changed back to previous behavior for interactive vs batch
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use argument for execution project id for queries, specifically in the sample query. This was a gap since the project id was already used for Storage API usage.
I think the SampleList class could also use some refactoring, but wanted to keep this PR small