separate alleles in M2 isActive and account for one-third substitution factor #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbenjamin
force-pushed
the
db_issue_6724_inactive
branch
from
e77cf16 to
642049f
Compare
takutosato
approved these changes
Sep 18, 2020
|
@davidbenjamin It looks like this one is approved and ready for merge -- did you want to get it in for Friday's release? |
|
Thanks @droazen, I do want to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6724
Closes #4885
Closes #3012 @takutosato The 1/3 factor fixes some missed low-AF calls reported on the forum. In effect our active region code was subtracting 5 from alt base qualities.
In addition to recouping some sensitivity it does also increase false positives in DREAM by a bit. However, I looked at these and without exception they were judgment calls that should be considered active, even if they are artifacts. If we made a PoN with the new changes to M2 I'm sure it would catch most of these.