Upgrade to Picard 2.23.3 #6717
Merged
Upgrade to Picard 2.23.3 #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry for Picard tools".
lbergelson
approved these changes
Jul 21, 2020
|
Yes, it does. Would you call that a bug or a feature ? |
droazen
reviewed
Aug 3, 2020
|
|
||
| // Turn off the Picard legacy parser and opt in to Barclay syntax for Picard tools. This should be replaced | ||
| // with a config setting once PR https://github.com/broadinstitute/gatk/pull/3447 is merged. | ||
| System.setProperty("picard.useLegacyParser", "false"); |
There was a problem hiding this comment.
Do we actually want to allow users to run Picard tools via GATK using the legacy syntax @cmnbroad ?
|
I'd call it a bug since we would like to remove the legacy parser at some point but I could be convinced either way. |
|
I was hoping to get rid of the remaining code in Picard that supports this, but I've reverted it for now. Back to you @droazen . |
droazen
approved these changes
Aug 4, 2020
droazen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.