Restart test jvm every few test classes #6093
Conversation
|
@lbergelson we might want to monitor how much this affects test time too. Maybe we should use a bigger number ? |
|
It looks like it made the tests substantially slower.... I'm not totally clear on why. Maybe because it has to re-optimize code every time it restarts the jvm. |
|
I'd try 100 or even 200. |
|
Unless I misunderstand, it's forking every 5 test classes not every 5 tests. So I'm surprised it's having such an impact. We only have a few hundred test classes, so I'm not sure 100 or 200 is going to do anything. I'll try 50 and see what it looks like time wise. |
testsettings.gradle
Outdated
| @@ -9,7 +9,7 @@ tasks.withType(Test) { | |||
| * anything else : run the non-cloud tests | |||
| */ | |||
| String TEST_TYPE = "$System.env.TEST_TYPE" | |||
|
|
|||
| forkEvery 50 | |||
There was a problem hiding this comment.
50 seems much better, though its a little hard to tell since there is so much variability in the normal case.
|
It still looks like it's adding a few minutes to the times... Are we still having a lot of a failures? I haven't been noticing them. |
|
@lbergelson Can we try this branch with "forkEvery" set to something high like 100 and see if it resolves the currently crop of intermittent Java 11 memory errors without adding to the runtime too much? |
* Adding forkEvery 5 to cause the test jvm to be restarted every few test classes. * This might fix a theoretical memory leak causing our builds to fail often.
lbergelson
force-pushed
the
lb_try_forking_jvm
branch
from
1885f0d to
e839fbc
Compare
This might help?