Support for GVCF validation with multiple contigs #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted the order validation for GVCF files into a separate method and included a check to reset the counter when a new contig is found. Contigs have to occur in continuous blocks; validation for files in which contigs occur alternatingly is not supported. - Added a set of integration tests for GVCF files with two and three contigs. Fixes #6023
jonn-smith
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a check to reset the counter when a new contig is found. Contigs have to
occur in continuous blocks; validation for files in which contigs occur
alternatingly is not supported.
Fixes #6023