Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gradle 5.4.1 #6007

Merged
merged 4 commits into from
Jun 27, 2019
Merged

Upgrade to gradle 5.4.1 #6007

merged 4 commits into from
Jun 27, 2019

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Jun 17, 2019

We are two major versions behind the latest gradle release. A later version is needed for upgrading Spark (#5990) and using BigQuery (#5928).

@tomwhite tomwhite mentioned this pull request Jun 17, 2019
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #6007 into master will decrease coverage by 51.742%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##              master     #6007        +/-   ##
================================================
- Coverage     86.931%   35.189%   -51.742%     
+ Complexity     32754     17310     -15444     
================================================
  Files           2016      2011         -5     
  Lines         151426    150912       -514     
  Branches       16623     16131       -492     
================================================
- Hits          131636     53105     -78531     
- Misses         13728     92939     +79211     
+ Partials        6062      4868      -1194
Impacted Files Coverage Δ Complexity Δ
...ls/variant/writers/GVCFBlockCombiningIterator.java 0% <0%> (-100%) 0% <0%> (-1%)
...ls/walkers/genotyper/HeterogeneousPloidyModel.java 0% <0%> (-100%) 0% <0%> (-14%)
...nder/utils/downsampling/FractionalDownsampler.java 0% <0%> (-100%) 0% <0%> (-17%)
...park/pathseq/MarkedOpticalDuplicateReadFilter.java 0% <0%> (-100%) 0% <0%> (-4%)
...otypecaller/RandomLikelihoodCalculationEngine.java 0% <0%> (-100%) 0% <0%> (-6%)
...r/utils/solver/UnivariateSolverSpecifications.java 0% <0%> (-100%) 0% <0%> (-4%)
...ute/hellbender/utils/hmm/UninformativeTestHMM.java 0% <0%> (-100%) 0% <0%> (-5%)
...ender/utils/svd/OjAlgoSingularValueDecomposer.java 0% <0%> (-100%) 0% <0%> (-3%)
...typer/afcalc/OriginalDiploidExactAFCalculator.java 0% <0%> (-100%) 0% <0%> (-15%)
...groups/StructuralVariantDiscoveryProgramGroup.java 0% <0%> (-100%) 0% <0%> (-3%)
... and 1384 more

@tomwhite
Copy link
Contributor Author

@lbergelson are you able to help with the docker/gradle failures? Also, there are likely more gradle changes needed for publishing artifacts, but I'm not sure what's needed or how to test those changes.

task wrapper(type: Wrapper) {
gradleVersion = '3.1'
wrapper {
gradleVersion = '5.4.1'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomwhite You need to update dockertest.gradle as well. The needed change is in my PR here: https://github.com/broadinstitute/gatk/pull/5928/files#diff-20d46fff5956131a01d67961f7ec15c0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @droazen, that fixes it. All the tests now pass. Are there any other changes needed before merging?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbergelson suggested that we test the maven artifact uploading, as he suspects it might break in this PR. We'll test that soon and get back to you on the results.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a deprecation warning and rebuild the wrapper itself. Haven't changed the publishing over yet.

@lbergelson
Copy link
Member

I fixed the artifact uploading as well now. Everything should be good provided tests are passing. It turned out to be something really simple and dumb.

@lbergelson lbergelson merged commit bc96bfd into master Jun 27, 2019
@lbergelson lbergelson deleted the tw_gradle_5 branch June 27, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants