Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't redundantly delete temporary directories in RSCriptExecutor. #5894

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

cmnbroad
Copy link
Collaborator

Fixes #5893.

@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #5894 into master will increase coverage by 0.008%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##              master    #5894       +/-   ##
==============================================
+ Coverage     86.843%   86.85%   +0.008%     
+ Complexity     32321    32319        -2     
==============================================
  Files           1991     1991               
  Lines         149308   149302        -6     
  Branches       16486    16485        -1     
==============================================
+ Hits          129663   129669        +6     
+ Misses         13630    13621        -9     
+ Partials        6015     6012        -3
Impacted Files Coverage Δ Complexity Δ
...dinstitute/hellbender/utils/R/RScriptExecutor.java 89.231% <ø> (+0.498%) 18 <0> (-2) ⬇️
...lotypecaller/readthreading/ReadThreadingGraph.java 88.971% <0%> (+0.245%) 159% <0%> (ø) ⬇️
...nder/utils/runtime/StreamingProcessController.java 67.773% <0%> (+0.474%) 33% <0%> (ø) ⬇️
...e/hellbender/engine/spark/SparkContextFactory.java 73.973% <0%> (+2.74%) 11% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+10%) 3% <0%> (ø) ⬇️
...nder/utils/smithwaterman/SmithWatermanAligner.java 81.818% <0%> (+13.636%) 2% <0%> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️

@droazen droazen self-assigned this Apr 22, 2019
@droazen droazen self-requested a review April 22, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception deleting RScriptExecutor temp directories
3 participants