Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SV QNameFinder to handle reads with negative unclipped starts #5864

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

cwhelan
Copy link
Member

@cwhelan cwhelan commented Apr 5, 2019

Attempts to fix #5685

I don't have test data from the users who reported the bug but it seemed like it was likely due to this issue.

@cwhelan cwhelan requested a review from tedsharpe April 5, 2019 20:36
@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #5864 into master will decrease coverage by 0.005%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #5864       +/-   ##
===============================================
- Coverage     87.068%   87.063%   -0.005%     
+ Complexity     32234     32232        -2     
===============================================
  Files           1985      1985               
  Lines         147653    147675       +22     
  Branches       16235     16235               
===============================================
+ Hits          128559    128571       +12     
- Misses         13167     13175        +8     
- Partials        5927      5929        +2
Impacted Files Coverage Δ Complexity Δ
...ender/tools/spark/sv/evidence/QNameFinderTest.java 96.078% <100%> (+2.745%) 4 <1> (+1) ⬆️
...ellbender/tools/spark/sv/evidence/QNameFinder.java 96% <100%> (+0.167%) 10 <0> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-40%) 1% <0%> (-2%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (-30%) 2% <0%> (ø)
...nder/utils/runtime/StreamingProcessController.java 67.773% <0%> (-0.948%) 33% <0%> (-1%)
...lotypecaller/readthreading/ReadThreadingGraph.java 88.725% <0%> (-0.245%) 159% <0%> (ø)

Copy link
Contributor

@tedsharpe tedsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@tedsharpe tedsharpe merged commit b1b1e89 into master Apr 6, 2019
@tedsharpe tedsharpe deleted the cw_qname_finder_negative_start_interval branch April 6, 2019 14:18
@tedsharpe
Copy link
Contributor

@cwhelan I merged it for you. Hope you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StructuralVariationDiscoveryPipelineSpark Exception: provided start is negative
3 participants