Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really don't output VCs with no ALT if * gets dropped #5844

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

ldgauthier
Copy link
Contributor

Fix botched squash, clarify test asserts

Fixes #5650

@codecov-io
Copy link

codecov-io commented Mar 28, 2019

Codecov Report

Merging #5844 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5844      +/-   ##
============================================
+ Coverage     87.05%   87.05%   +<.01%     
  Complexity    32157    32157              
============================================
  Files          1978     1978              
  Lines        147433   147433              
  Branches      16206    16206              
============================================
+ Hits         128350   128351       +1     
+ Misses        13171    13168       -3     
- Partials       5912     5914       +2
Impacted Files Coverage Δ Complexity Δ
...ls/walkers/genotyper/GenotypingEngineUnitTest.java 93.4% <0%> (ø) 11 <0> (ø) ⬇️
...nder/tools/walkers/genotyper/GenotypingEngine.java 70.24% <100%> (ø) 73 <0> (+1) ⬆️
...titute/hellbender/tools/walkers/GenotypeGVCFs.java 90.71% <0%> (-0.43%) 100% <0%> (-1%)
...lbender/utils/variant/GATKVariantContextUtils.java 87.3% <0%> (-0.31%) 244% <0%> (-2%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...nder/utils/runtime/StreamingProcessController.java 67.77% <0%> (+0.47%) 33% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c24e67...43708f1. Read the comment docs.

@droazen droazen merged commit 21da1c0 into master Mar 28, 2019
@droazen droazen deleted the ldg_actuallyFix5661 branch March 28, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants