-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Picard version in mitochondria WDL #5818
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5818 +/- ##
===============================================
- Coverage 87.031% 19.041% -67.99%
+ Complexity 32107 4583 -27524
===============================================
Files 1972 1234 -738
Lines 147194 71206 -75988
Branches 16201 11401 -4800
===============================================
- Hits 128104 13558 -114546
- Misses 13184 55608 +42424
+ Partials 5906 2040 -3866
|
Without seeing the dockerfile I don't actually know what changed. Is that a Picard jar from master in there or just a branch? |
Good point, here's the PR in dsde-pipelines: https://github.com/broadinstitute/dsde-pipelines/pull/718/files It just updates the Picard version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Can you note the single-end fix in the commit message so it magically propagates to the release notes?
Meanwhile I'm going to go cry over the fact that GATK4beta5 is still in the GitC docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great PR!
9b6cc5a
to
3ae179e
Compare
This update means the pipeline won't die on single-ended reads (it just filters them out).