Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gatk-5449 #5799

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Fix for gatk-5449 #5799

merged 2 commits into from
Mar 28, 2019

Conversation

kgururaj
Copy link
Collaborator

CI test

@droazen droazen requested a review from ldgauthier March 15, 2019 17:10
@droazen droazen requested review from droazen and removed request for ldgauthier March 15, 2019 17:11
@droazen droazen assigned droazen and unassigned ldgauthier Mar 15, 2019
@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #5799 into master will decrease coverage by 2.577%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##              master     #5799       +/-   ##
===============================================
- Coverage     87.041%   84.463%   -2.577%     
+ Complexity     32076     31118      -958     
===============================================
  Files           1977      1977               
  Lines         147082    147085        +3     
  Branches       16171     16171               
===============================================
- Hits          128021    124233     -3788     
- Misses         13157     16917     +3760     
- Partials        5904      5935       +31
Impacted Files Coverage Δ Complexity Δ
...ls/genomicsdb/GenomicsDBImportIntegrationTest.java 9.251% <0%> (-79.219%) 2 <0> (-78)
...s/GermlineContigPloidyModelArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-4%)
...mlineContigPloidyHybridADVIArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-3%)
...ments/GermlineCNVHybridADVIArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-3%)
...r/arguments/GermlineCallingArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-4%)
...ect/filtering/ChimericOriginalAlignmentFilter.java 0% <0%> (-100%) 0% <0%> (-8%)
...tools/examples/ExampleStreamingPythonExecutor.java 0% <0%> (-96.667%) 0% <0%> (-8%)
...ents/GermlineDenoisingModelArgumentCollection.java 0% <0%> (-96.552%) 0% <0%> (-4%)
...number/arguments/HybridADVIArgumentCollection.java 0% <0%> (-94.915%) 0% <0%> (-3%)
...ct/CreateSomaticPanelOfNormalsIntegrationTest.java 3.448% <0%> (-94.253%) 2% <0%> (-8%)
... and 111 more

Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't confirm that the test fails without the fix, but that test replicates my issue.

@droazen
Copy link
Contributor

droazen commented Mar 27, 2019

@kgururaj If you can resolve the remaining conflict, we can get this one merged now that tests are passing.

@kgururaj
Copy link
Collaborator Author

Done

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@droazen droazen merged commit c7ce353 into master Mar 28, 2019
@droazen droazen deleted the gatk-5449 branch March 28, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants