Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to remove outdated references to the Intel conda environment. #5753

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Mar 4, 2019

There is only a single conda environment now; remove dangling references to the intel conda environment from the README.md.

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Merge when ready @cmnbroad

@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Mar 4, 2019

@bhanugandham @sooheelee BTW, this tutorial is bit out of date - it refers to tools by names that no longer exist (ie. NeuralNetInference -> CNNscoreVariants).

@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #5753 into master will decrease coverage by 6.693%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5753       +/-   ##
===============================================
- Coverage     86.982%   80.288%   -6.693%     
+ Complexity     31860     30238     -1622     
===============================================
  Files           1943      1943               
  Lines         146770    146770               
  Branches       16224     16224               
===============================================
- Hits          127663    117839     -9824     
- Misses         13194     23217    +10023     
+ Partials        5913      5714      -199
Impacted Files Coverage Δ Complexity Δ
...kers/filters/VariantFiltrationIntegrationTest.java 0.826% <0%> (-99.174%) 1% <0%> (-25%)
...dorientation/CollectF1R2CountsIntegrationTest.java 0.917% <0%> (-99.083%) 1% <0%> (-12%)
.../walkers/bqsr/BaseRecalibratorIntegrationTest.java 1.031% <0%> (-98.969%) 1% <0%> (-7%)
...ers/vqsr/FilterVariantTranchesIntegrationTest.java 1.053% <0%> (-98.947%) 1% <0%> (-5%)
...s/variantutils/VariantsToTableIntegrationTest.java 1.205% <0%> (-98.795%) 1% <0%> (-20%)
...ientation/ReadOrientationModelIntegrationTest.java 1.667% <0%> (-98.333%) 1% <0%> (-5%)
...on/FindBreakpointEvidenceSparkIntegrationTest.java 1.754% <0%> (-98.246%) 1% <0%> (-6%)
...bender/tools/spark/PileupSparkIntegrationTest.java 2.041% <0%> (-97.959%) 2% <0%> (-13%)
...tute/hellbender/tools/FlagStatIntegrationTest.java 2.083% <0%> (-97.917%) 1% <0%> (-5%)
...rs/variantutils/SelectVariantsIntegrationTest.java 0.25% <0%> (-97.75%) 1% <0%> (-70%)
... and 153 more

@bhanugandham
Copy link
Contributor

@cmnbroad Thank you, I will look into it.

@cmnbroad cmnbroad force-pushed the cn_update_conda_readme branch from c387362 to 63530d6 Compare March 4, 2019 23:23
@cmnbroad cmnbroad merged commit 0f0c22b into master Mar 5, 2019
@cmnbroad cmnbroad deleted the cn_update_conda_readme branch March 5, 2019 13:10
@bhanugandham
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants