-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overfiltering in M2 in GGA alleles with no reads #5743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are sure that there is no downstream issues with doing this. then merge away.
@Override | ||
protected int aggregate(final List<Integer> values) { | ||
return values.isEmpty() ? 0 : MathUtils.median(Ints.toArray(values)); | ||
return values.isEmpty() ? VALUE_FOR_NO_READS : MathUtils.median(Ints.toArray(values)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to do this for all runs of M2, not just the GGA runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just seems like there could be a downstream effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because any allele with no reads should have no say either way. But also, an allele with no reads can't occur outside of GGA mode.
Codecov Report
@@ Coverage Diff @@
## master #5743 +/- ##
===============================================
- Coverage 87.079% 80.259% -6.821%
+ Complexity 31918 30263 -1655
===============================================
Files 1942 1942
Lines 146909 146909
Branches 16242 16242
===============================================
- Hits 127927 117907 -10020
- Misses 13062 23290 +10228
+ Partials 5920 5712 -208
|
085062e
to
6323853
Compare
Closes #5695.