bring Funcotator changes to M2 NIO WDL #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5742 +/- ##
===============================================
- Coverage 87.003% 87.002% -0.001%
Complexity 32091 32091
===============================================
Files 1975 1975
Lines 147184 147184
Branches 16228 16228
===============================================
- Hits 128054 128053 -1
Misses 13225 13225
- Partials 5905 5906 +1
|
jonn-smith
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
This looks fine. @davidbenjamin Did you happen to test it just to double-check there are no errors?
|
Yes, but I've been waiting to merge #5688 to rebase on top of it and test again. Then I will merge this one. |
davidbenjamin
force-pushed
the
db_m2_funco_nio
branch
from
342c15f to
13b7dd0
Compare
|
Tested it again on FC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonn-smith I should have spotted this earlier but unfortunately M2 still has to carry around two WDLs. I just copied your changes from #5735 verbatim.