Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAM support in Mutect2 WDL #5668

Merged
merged 1 commit into from
Feb 14, 2019
Merged

CRAM support in Mutect2 WDL #5668

merged 1 commit into from
Feb 14, 2019

Conversation

davidbenjamin
Copy link
Contributor

@takutosato The engine team tells us not to run GATK tools on CRAM files for another several months while Joel fixes htsjdk bugs. This change lets the M2 WDL accept CRAMs by converting to BAM.

@LeeTL1220 This is needed for the SFARI induced pluripotency project.

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #5668 into master will decrease coverage by 0.001%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5668       +/-   ##
===============================================
- Coverage     87.049%   87.048%   -0.001%     
+ Complexity     31709     31708        -1     
===============================================
  Files           1940      1940               
  Lines         146172    146172               
  Branches       16130     16130               
===============================================
- Hits          127242    127240        -2     
- Misses         13042     13045        +3     
+ Partials        5888      5887        -1
Impacted Files Coverage Δ Complexity Δ
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-30%) 1% <0%> (-2%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...lotypecaller/readthreading/ReadThreadingGraph.java 88.861% <0%> (+0.253%) 145% <0%> (+1%) ⬆️

Copy link
Contributor

@takutosato takutosato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Looks good otherwise.

String unfiltered_name = output_basename + "-unfiltered"
String filtered_name = output_basename + "-filtered"
String funcotated_name = output_basename + "-funcotated"

String output_vcf_name = basename(tumor_bam, ".bam") + ".vcf"
String output_vcf_name = basename(tumor_reads, ".bam") + ".vcf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should probably say String output_vcf_name = output_basename + ".vcf"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

@davidbenjamin davidbenjamin merged commit acdb7f5 into master Feb 14, 2019
@davidbenjamin davidbenjamin deleted the db_m2_cram branch February 14, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants