Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing an extraneous cigar copy from referenceConfidenceCalculation #5652

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

jamesemery
Copy link
Collaborator

This was showing up in the profile, as with a few other places this was copying the cigar for each read over each pileup, which is not efficient.
Before:
screen shot 2019-02-07 at 11 55 24 am
After:
screen shot 2019-02-07 at 12 20 16 pm

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #5652 into master will increase coverage by 0.005%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##              master    #5652       +/-   ##
==============================================
+ Coverage     87.035%   87.04%   +0.005%     
- Complexity     31726    31728        +2     
==============================================
  Files           1943     1943               
  Lines         146193   146193               
  Branches       16141    16141               
==============================================
+ Hits          127239   127246        +7     
+ Misses         13067    13060        -7     
  Partials        5887     5887
Impacted Files Coverage Δ Complexity Δ
...kers/haplotypecaller/ReferenceConfidenceModel.java 92.391% <100%> (ø) 69 <0> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good change

@jamesemery jamesemery merged commit 50495b2 into master Feb 7, 2019
@jamesemery jamesemery deleted the je_HaplotypeCallerMicroOptimization5 branch February 7, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants