Replacing some uses of PrintWriter #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lbergelson
commented
Nov 29, 2018
lbergelson
commented
- PrintWriter doesn't throw exceptions on write failures and might therefore lead to unexpectedly trunacated data being produced without any notification
- replacing it's use in MetricsUtils and MafOutputRenderer where it might cause problems
- partial fix for Remove uses of PrintWriter #5458
* PrintWriter doesn't throw exceptions on write failures and might therefore lead to unexpectedly trunacated data being produced without any notification * replacing it's use in MetricsUtils and MafOutputRenderer where it might cause problems * partial fix for #5458
jonn-smith
requested changes
Nov 29, 2018
| @@ -260,7 +261,7 @@ public MafOutputRenderer(final Path outputFilePath, | |||
|
|
|||
| // Open the output object: | |||
| try { | |||
| printWriter = new PrintWriter(Files.newOutputStream(outputFilePath)); | |||
| writer = new PrintWriter(Files.newOutputStream(outputFilePath)); | |||
There was a problem hiding this comment.
I think you missed one. :P
jonn-smith
approved these changes
Nov 29, 2018
Codecov Report
@@ Coverage Diff @@
## master #5461 +/- ##
==============================================
- Coverage 86.99% 86.985% -0.005%
+ Complexity 31202 31200 -2
==============================================
Files 1909 1909
Lines 144184 144195 +11
Branches 15951 15951
==============================================
+ Hits 125425 125428 +3
- Misses 12991 12999 +8
Partials 5768 5768
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.