-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved validation test data out of large files area. #5381
Conversation
Now the validation test data sets are in the normal git file repository. This allows them to be visually inspected for differences when they have changed (during a code review). Fixes #5379
@jonn-smith Something is weird here, it looks like the the stubs are committed now by accident. That's what I see if I check it out locally. They're still valid git-lfs stubs, so running a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The state of the files is really wierd, should not be merged until it's resolve, see my other comment.
Good catch @lbergelson -- @jonn-smith could you fix this following Louis's instructions above? If you do it correctly, the diff on github should show that you've added thousands of lines. |
Gross. OK. I thought a I'll fix it up now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now @jonn-smith -- merge once tests pass.
Codecov Report
@@ Coverage Diff @@
## master #5381 +/- ##
===============================================
+ Coverage 86.933% 86.933% +<.001%
Complexity 30327 30327
===============================================
Files 1849 1849
Lines 140801 140802 +1
Branches 15477 15477
===============================================
+ Hits 122402 122403 +1
Misses 12735 12735
Partials 5664 5664
|
) * Moved validation test data out of large files area. Now the validation test data sets are in the normal git file repository. This allows them to be visually inspected for differences when they have changed (during a code review). Fixes broadinstitute#5379 * Removing test files. * Adding back in test files outside of gitlfs to fix lfs file problem.
Now the validation test data sets are in the normal git file repository.
This allows them to be visually inspected for differences when they have
changed (during a code review).
Fixes #5379