HaplotypeCallerIntegrationTest: add a boolean toggle to update the expected outputs for all exact-match-based tests #5324
Conversation
|
@ldgauthier please review |
|
Thanks @droazen, this will be super helpful |
Codecov Report
@@ Coverage Diff @@
## master #5324 +/- ##
===============================================
+ Coverage 86.795% 86.795% +<.001%
- Complexity 30125 30126 +1
===============================================
Files 1843 1843
Lines 139485 139487 +2
Branches 15376 15376
===============================================
+ Hits 121066 121068 +2
+ Misses 12827 12826 -1
- Partials 5592 5593 +1
|
There was a problem hiding this comment.
Very helpful indeed. I've been doing this with debug mode and there's just so much clicking.
Do you have any thoughts on a safety mechanism to make sure something doesn't get merged with this turned on? Of course a conscientious reviewer like yourself would catch it, but I wouldn't want you to have to review all the HaplotypeCaller PRs. Maybe Travis should have a check for the number of integration tests run in this class?
|
@ldgauthier Good point! I'll add a test that fails if the boolean toggle is left turned on. |
…pected outputs for all exact-match-based tests
droazen
force-pushed
the
dr_haplotypecallerintegrationtest_toggle
branch
from
4a3aef1 to
7a1d05d
Compare
|
Added a new test to assert that the toggle is off -- back to you @ldgauthier |
| * Make sure that someone didn't leave the UPDATE_EXACT_MATCH_EXPECTED_OUTPUTS toggle turned on | ||
| */ | ||
| @Test | ||
| public void assertThatExpectedOutputUpdateToggleIsDisabled() { |
…pected outputs for all exact-match-based tests (broadinstitute#5324)
No description provided.