Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExampleReadWalkerWithVariantsSpark.java and tests #5289

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Oct 8, 2018

Includes a test for the non-Spark version, and tests the two produce the same result.

Fixes #5276.

@tomwhite tomwhite requested a review from droazen October 8, 2018 10:37
@droazen droazen self-assigned this Oct 9, 2018
@droazen droazen requested review from jamesemery and removed request for droazen November 16, 2018 00:01
@droazen droazen assigned jamesemery and unassigned droazen Nov 16, 2018
@droazen
Copy link
Contributor

droazen commented Nov 16, 2018

Reassigning to @jamesemery

Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pretty simple set of tests. I don't see a particular reason not to approve this

@codecov-io
Copy link

Codecov Report

Merging #5289 into master will increase coverage by 0.318%.
The diff coverage is 83.636%.

@@               Coverage Diff               @@
##              master     #5289       +/-   ##
===============================================
+ Coverage     86.776%   87.094%   +0.318%     
- Complexity     29888     30529      +641     
===============================================
  Files           1834      1859       +25     
  Lines         138473    141539     +3066     
  Branches       15241     15540      +299     
===============================================
+ Hits          120162    123272     +3110     
+ Misses         12760     12620      -140     
- Partials        5551      5647       +96
Impacted Files Coverage Δ Complexity Δ
...itute/hellbender/engine/spark/ReadWalkerSpark.java 88.889% <ø> (+16.667%) 11 <0> (+3) ⬆️
.../ExampleReadWalkerWithVariantsIntegrationTest.java 100% <100%> (ø) 3 <3> (?)
...pleReadWalkerWithVariantsSparkIntegrationTest.java 100% <100%> (ø) 3 <3> (?)
...s/examples/ExampleReadWalkerWithVariantsSpark.java 68.966% <68.966%> (ø) 6 <6> (?)
...ls/funcotator/metadata/VcfFuncotationMetadata.java 71.429% <0%> (-28.571%) 8% <0%> (+3%)
...hellbender/tools/walkers/vqsr/CNNVariantTrain.java 60% <0%> (-20.645%) 4% <0%> (ø)
...der/tools/walkers/annotator/RMSMappingQuality.java 83.607% <0%> (-10.208%) 41% <0%> (+1%)
...der/tools/walkers/mutect/M2ArgumentCollection.java 87.5% <0%> (-6.944%) 8% <0%> (+5%)
...itute/hellbender/tools/walkers/mutect/Mutect2.java 81.395% <0%> (-6.483%) 23% <0%> (+4%)
...bender/tools/walkers/mutect/FilterMutectCalls.java 92.5% <0%> (-4.722%) 14% <0%> (+2%)
... and 149 more

@tomwhite tomwhite merged commit e6b6330 into master Nov 21, 2018
@tomwhite tomwhite deleted the tw_spark_walker_tests branch November 21, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants