Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding SparkTestUtils.roundTripThroughJavaSerialization #5257

Merged
merged 1 commit into from
Oct 4, 2018
Merged

adding SparkTestUtils.roundTripThroughJavaSerialization #5257

merged 1 commit into from
Oct 4, 2018

Conversation

lbergelson
Copy link
Member

  • adding in a new SparkTestUtils.roundTripThroughJavaSerialization method
  • updating existing code to use the new method

@lbergelson
adding SparkTestUtils.roundTripThroughJavaSerialization
c1ae4de 
* adding in a new SparkTestUtils.roundTripThroughJavaSerialization method
* updating existing code to use the new method
@lbergelson lbergelson requested a review from jamesemery October 3, 2018 21:32
@codecov-io
Copy link

Codecov Report

Merging #5257 into master will increase coverage by 0.002%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #5257       +/-   ##
===============================================
+ Coverage     86.757%   86.759%   +0.002%     
- Complexity     29832     29834        +2     
===============================================
  Files           1828      1828               
  Lines         138115    138103       -12     
  Branches       15227     15225        -2     
===============================================
- Hits          119824    119817        -7     
+ Misses         12744     12741        -3     
+ Partials        5547      5545        -2
Impacted Files Coverage Δ Complexity Δ
.../datasources/ReferenceFileSparkSourceUnitTest.java 86.364% <100%> (-2.098%) 4 <0> (ø)
...titute/hellbender/engine/FeatureInputUnitTest.java 90.526% <100%> (+1.206%) 23 <1> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

jamesemery
jamesemery approved these changes Oct 4, 2018
View reviewed changes
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds helpful test method 👍

...org/broadinstitute/hellbender/engine/spark/datasources/ReferenceFileSparkSourceUnitTest.java
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
ObjectOutputStream os = new ObjectOutputStream(baos);
os.writeObject(referenceFileSource);
//can we serialize it?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can!

@lbergelson lbergelson merged commit 930a0dd into master Oct 4, 2018
@lbergelson lbergelson deleted the lb_add_serialization_test_method branch October 4, 2018 16:28
EdwardDixon pushed a commit to EdwardDixon/gatk that referenced this pull request Nov 9, 2018
@lbergelson @EdwardDixon
adding SparkTestUtils.roundTripThroughJavaSerialization (broadinstitu…
0adf510 
…te#5257)

* adding in a new SparkTestUtils.roundTripThroughJavaSerialization method
* updating existing code to use the new method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesemery jamesemery jamesemery approved these changes

Assignees

@jamesemery jamesemery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbergelson @codecov-io @jamesemery