-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating SimpleGermlineTagger and somatic CNV experimental post-processing workflow #5252
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3513e38
Changes to the simple germline tagging. Still based on heuristics...
LeeTL1220 c4ea696
Last minute doc change.
LeeTL1220 a91b884
Last last minute doc change.
LeeTL1220 bccd943
Addressed all PR comments minus one.
LeeTL1220 4273046
Addressing last PR comment.
LeeTL1220 a41679d
Addressing a missed PR comment.
LeeTL1220 d6f8f96
Making reciprocal overlap range 0.0, 1.0
LeeTL1220 6d700c4
Two more last minute obvious unit tests for reciprocal overlap.
LeeTL1220 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
scripts/unsupported/combine_tracks_postprocessing_cnv/aggregate_combined_tracks.wdl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# Unsupported workflow that concatenates the IGV compatible files generated by multiple runs of combine_tracks.wdl | ||
workflow AggregateCombinedTracksWorkflow { | ||
String group_id | ||
Array[File] tumor_with_germline_filtered_segs | ||
Array[File] normals_igv_compat | ||
Array[File] tumors_igv_compat | ||
|
||
call TsvCat as TsvCatTumorGermlinePruned { | ||
input: | ||
input_files = tumor_with_germline_filtered_segs, | ||
id = group_id + "_TumorGermlinePruned" | ||
} | ||
|
||
call TsvCat as TsvCatTumor { | ||
input: | ||
input_files = tumors_igv_compat, | ||
id = group_id + "_Tumor" | ||
} | ||
|
||
call TsvCat as TsvCatNormal { | ||
input: | ||
input_files = normals_igv_compat, | ||
id = group_id + "_Normal" | ||
} | ||
|
||
output { | ||
File cnv_postprocessing_aggregated_tumors_pre = TsvCatTumor.aggregated_tsv | ||
File cnv_postprocessing_aggregated_tumors_post = TsvCatTumorGermlinePruned.aggregated_tsv | ||
File cnv_postprocessing_aggregated_normals = TsvCatNormal.aggregated_tsv | ||
} | ||
} | ||
|
||
|
||
task TsvCat { | ||
|
||
String id | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is some white space funkiness here and throughout the other WDLs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed it here. Will be on lookout in other files. |
||
Array[File] input_files | ||
|
||
command <<< | ||
set -e | ||
|
||
head -1 ${input_files[0]} > ${id}.aggregated.seg | ||
|
||
for FILE in ${sep=" " input_files} | ||
do | ||
egrep -v "CONTIG|Chromosome" $FILE >> ${id}.aggregated.seg | ||
done | ||
>>> | ||
|
||
output { | ||
File aggregated_tsv="${id}.aggregated.seg" | ||
} | ||
|
||
runtime { | ||
docker: "ubuntu:16.04" | ||
memory: "2 GB" | ||
cpu: "1" | ||
disks: "local-disk 100 HDD" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. Can you do a find-and-replace on other instances? Should be a few more in the other somatic/germline WDLs as well as the docs. Also may be some instances of
PreprocessIntervals.padding
.BTW, where are we with Cromwell exposing task-level parameters automatically for subworkflows? Do we still need to expose all parameters in this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and done for padding as well.
Your comment here is related to broadinstitute/cromwell#2912 ... I have not heard about any update on this.