-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating google-cloud-java nio to 0.62.0 #5194
Conversation
lbergelson
commented
Sep 17, 2018
- updating google-cloud-java 0.59.0 -> 0.62.0
- this includes retries on 502 errors see google-cloud-nio: retry on 502 errors, and increase max depth when doing channel reopens googleapis/google-cloud-java#3557
* updating google-cloud-java 0.59.0 -> 0.62.0 * this includes retries on 502 errors see googleapis/google-cloud-java#3557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge when tests pass @lbergelson
Note that the PR build has failed twice in a row with:
|
weird... |
@lbergelson This is failing deterministically with the above error on the OracleJDK only... |
Codecov Report
@@ Coverage Diff @@
## master #5194 +/- ##
===========================================
Coverage 86.806% 86.806%
Complexity 29679 29679
===========================================
Files 1815 1815
Lines 137203 137203
Branches 15144 15144
===========================================
Hits 119101 119101
Misses 12619 12619
Partials 5483 5483 |
Aha, after clearing the travis cache for the PR build it passed! Merging |