Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CountingVariantFilter. #4954

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Conversation

cmnbroad
Copy link
Collaborator

Fixes #4747.

@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #4954 into master will decrease coverage by 1.695%.
The diff coverage is 95.238%.

@@               Coverage Diff               @@
##              master     #4954       +/-   ##
===============================================
- Coverage     86.753%   85.058%   -1.695%     
+ Complexity     29767     29142      -625     
===============================================
  Files           1825      1813       -12     
  Lines         137744    137448      -296     
  Branches       15181     15579      +398     
===============================================
- Hits          119497    116910     -2587     
- Misses         12729     15090     +2361     
+ Partials        5518      5448       -70
Impacted Files Coverage Δ Complexity Δ
...titute/hellbender/tools/funcotator/Funcotator.java 85.976% <0%> (+0.869%) 46 <1> (+31) ⬆️
...ellbender/tools/walkers/vqsr/CNNScoreVariants.java 75% <0%> (+0.243%) 40 <1> (ø) ⬇️
...der/tools/walkers/variantutils/SelectVariants.java 79.586% <100%> (-0.06%) 115 <3> (-4)
...llbender/engine/filters/VariantFilterUnitTest.java 93.333% <100%> (+3.089%) 10 <4> (+4) ⬆️
...institute/hellbender/engine/VariantWalkerBase.java 100% <100%> (ø) 14 <2> (ø) ⬇️
...ellbender/engine/filters/VariantFilterLibrary.java 90% <100%> (+56.667%) 1 <1> (ø) ⬇️
...titute/hellbender/engine/TwoPassVariantWalker.java 95.238% <100%> (+0.238%) 4 <1> (ø) ⬇️
.../hellbender/tools/walkers/mutect/FilterResult.java 0% <0%> (-100%) 0% <0%> (-7%)
...r/tools/walkers/readorientation/ArtifactPrior.java 0% <0%> (-100%) 0% <0%> (-9%)
...tools/walkers/readorientation/ReadOrientation.java 0% <0%> (-100%) 0% <0%> (-3%)
... and 430 more

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

@cmnbroad cmnbroad force-pushed the cn_counting_variant_filter branch 2 times, most recently from 9d62bfb to 167ccf7 Compare July 2, 2018 17:14
@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Jul 3, 2018

So, the problem with this is that the counting filters use the filter class name to report summaries, and most of the variant filters that we have are implemented using lambdas, so they have no recognizable name. Before this is merged I'll want to reimplement the handful of existing filters used by CNNScoreVariants and Funcotator to use static, named classes in VariantFilterLibrary.

@cmnbroad cmnbroad force-pushed the cn_counting_variant_filter branch 2 times, most recently from 92490cc to 8c88874 Compare July 3, 2018 15:14
@cmnbroad cmnbroad force-pushed the cn_counting_variant_filter branch from 8c88874 to 2a34d4b Compare August 2, 2018 20:28
@cmnbroad
Copy link
Collaborator Author

@lbergelson I had to add another commit to this after you reviewed it (see my note above), so back to you for another look.

@cmnbroad cmnbroad assigned lbergelson and unassigned cmnbroad Aug 27, 2018
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmnbroad This looks good to me 👍

@lbergelson
Copy link
Member

Looks like this needs a rebase, feel free to merge after unless there are crazy changes needed.

@lbergelson lbergelson assigned cmnbroad and unassigned lbergelson Oct 2, 2018
@cmnbroad cmnbroad force-pushed the cn_counting_variant_filter branch from 2a34d4b to 934de50 Compare October 3, 2018 12:09
@cmnbroad cmnbroad force-pushed the cn_counting_variant_filter branch from 934de50 to ed21e64 Compare October 3, 2018 18:51
@cmnbroad cmnbroad merged commit d12121c into master Oct 3, 2018
@cmnbroad cmnbroad deleted the cn_counting_variant_filter branch October 3, 2018 20:00
EdwardDixon pushed a commit to EdwardDixon/gatk that referenced this pull request Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants