Updated top-level class documentation for Funcotator. #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTL1220
reviewed
Apr 12, 2018
| @@ -172,6 +174,7 @@ | |||
| * -R reference.fasta \ | |||
| * -V input.vcf \ | |||
| * -O output.vcf \ | |||
There was a problem hiding this comment.
You sure the output file should still have a name of ".vcf" if the output format is MAF?
There was a problem hiding this comment.
Good point. Fixed!
|
It's supposed to ignore transcript version numbers, but it looks like right now it doesn't. I'll add in an issue for it. |
jonn-smith
force-pushed
the
jts_funcotator_documentation_4654
branch
from
5419c9a to
2f0e699
Compare
Codecov Report
@@ Coverage Diff @@
## master #4655 +/- ##
==============================================
+ Coverage 86.48% 86.485% +0.005%
- Complexity 29166 29168 +2
==============================================
Files 1813 1813
Lines 135256 135256
Branches 15027 15027
==============================================
+ Hits 116969 116976 +7
+ Misses 12825 12818 -7
Partials 5462 5462
|
LeeTL1220
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
@jonn-smith Double check that this is okay to merge, but it looks like you addressed my comment previously.
|
It's still accurate, but this info needs to be added to. I'll merge it, but we'll need to do another one of these in relatively short order. |
EdwardDixon
pushed a commit
to EdwardDixon/gatk
that referenced
this pull request
Nov 9, 2018
…#4655) * Updated top-level class documentation for Funcotator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4654