prevent uploadArchives from including distZip and distTar #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4569 +/- ##
==============================================
+ Coverage 79.84% 79.846% +0.006%
- Complexity 16962 16964 +2
==============================================
Files 1062 1062
Lines 61676 61676
Branches 9983 9983
==============================================
+ Hits 49242 49246 +4
+ Misses 8542 8538 -4
Partials 3892 3892
|
|
confirmed that no zip or tar is uploaded here: |
droazen
suggested changes
Mar 23, 2018
| } | ||
| //remove zip and tar added by the application plugin |
There was a problem hiding this comment.
Will our maven upload still have all the artifacts required by maven central? Isn't there a javadoc zip?
lbergelson
force-pushed
the
lb_remove_waste_from_uploads
branch
from
ba81bae to
7cd2fd9
Compare
droazen
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4567