Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify HaplotypeBAMWriter code. #944

Closed
cmnbroad opened this issue Oct 2, 2015 · 1 comment
Closed

Simplify HaplotypeBAMWriter code. #944

cmnbroad opened this issue Oct 2, 2015 · 1 comment
Assignees
@cmnbroad
Labels
coding learn GATK Suitable for GATK beginners

Comments

@cmnbroad
Copy link
Collaborator

cmnbroad commented Oct 2, 2015

The HaplotypeBAMWriter implementation as ported from GATK is currently spread out over 5 classes, with a base class and two subclasses for the writers and a base class and one subclass to represent the writer destination. All of the functionality can be reduced to one simple HaplotypeBAMWriter class (or possibly two if we want to keep the destination separate).
@cmnbroad cmnbroad self-assigned this Oct 2, 2015
@akiezun akiezun added the coding label Oct 3, 2015
@davidbenjamin davidbenjamin added the learn GATK Suitable for GATK beginners label Jun 19, 2018
kvinter1 added a commit that referenced this issue Aug 17, 2018
@kvinter1
Attempt to fix #944.
5cbbce3
@kvinter1 kvinter1 mentioned this issue Aug 17, 2018
Merged
cmnbroad pushed a commit that referenced this issue Aug 30, 2018
@kvinter1 @cmnbroad
Simplify HaplotypeBAMWriter code. #944 (#5122)
da950e2
@kvinter1
Copy link
Contributor

See pull request: #5122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmnbroad cmnbroad

Labels
coding learn GATK Suitable for GATK beginners
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akiezun @davidbenjamin @cmnbroad @kvinter1