-
Notifications
You must be signed in to change notification settings - Fork 594
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
responding to review comments, also added unit test for generateRefer…
…encePairsAgainstDictionary()
- Loading branch information
Showing
17 changed files
with
167 additions
and
115 deletions.
There are no files selected for viewing
134 changes: 76 additions & 58 deletions
134
src/main/java/org/broadinstitute/hellbender/tools/reference/CheckReferenceCompatibility.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...eckReferenceCompatibility/expected.testReferenceCompatibilityBAMWithMD5s_exactmatch.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withmd5s.bam | ||
Reference Compatibility | ||
hg19mini.fasta Compatible, the sequence dictionaries exactly match | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE The sequence dictionaries exactly match |
4 changes: 2 additions & 2 deletions
4
...ReferenceCompatibility/expected.testReferenceCompatibilityBAMWithMD5s_notcompatible.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withmd5s.bam | ||
Reference Compatibility | ||
hg19mini_missingchr3.fasta Not compatible. Status: [SUPERSET]. Run CompareReferences tool for more information on reference differences. | ||
Reference Compatibility Summary | ||
hg19mini_missingchr3.fasta NOT_COMPATIBLE Status: [SUPERSET]. Run CompareReferences tool for more information on reference differences. |
4 changes: 2 additions & 2 deletions
4
...e/CheckReferenceCompatibility/expected.testReferenceCompatibilityBAMWithMD5s_subset.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withmd5s_missingchr1.bam | ||
Reference Compatibility | ||
hg19mini.fasta Compatible, the sequence dictionary in reads_data_source_test1_withmd5s_missingchr1.bam is a subset of the hg19mini.fasta reference sequence dictionary. Missing sequence(s): [1] | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE_SUBSET The sequence dictionary in reads_data_source_test1_withmd5s_missingchr1.bam is a subset of the hg19mini.fasta reference sequence dictionary. Missing sequence(s): [1] |
4 changes: 2 additions & 2 deletions
4
...ReferenceCompatibility/expected.testReferenceCompatibilityBAMWithoutMD5s_compatible.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withoutmd5s.bam | ||
Reference Compatibility | ||
hg19mini.fasta All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |
4 changes: 2 additions & 2 deletions
4
...erenceCompatibility/expected.testReferenceCompatibilityBAMWithoutMD5s_notcompatible.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withoutmd5s.bam | ||
Reference Compatibility | ||
hg19mini_missingchr3.fasta Not compatible. Status: COMMON_SUBSET. Run CompareReferences tool for more information on reference differences. | ||
Reference Compatibility Summary | ||
hg19mini_missingchr3.fasta NOT_COMPATIBLE Status: COMMON_SUBSET. Run CompareReferences tool for more information on reference differences. |
4 changes: 2 additions & 2 deletions
4
...heckReferenceCompatibility/expected.testReferenceCompatibilityBAMWithoutMD5s_subset.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withoutmd5s_missingchr1.bam | ||
Reference Compatibility | ||
hg19mini.fasta All sequence names and lengths present in the sequence dictionaries match, but reads_data_source_test1_withoutmd5s_missingchr1.bam is a subset of hg19mini.fasta. Missing sequence(s): [1]. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE_SUBSET All sequence names and lengths present in the sequence dictionaries match, but reads_data_source_test1_withoutmd5s_missingchr1.bam is a subset of hg19mini.fasta. Missing sequence(s): [1]. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |
9 changes: 5 additions & 4 deletions
9
...renceCompatibility/expected.testReferenceCompatibilityMultipleReferencesBAMWithMD5s.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
#Current Reference: reads_data_source_test1_withmd5s_missingchr1.bam | ||
Reference Compatibility | ||
hg19mini.fasta Compatible, the sequence dictionary in reads_data_source_test1_withmd5s_missingchr1.bam is a subset of the hg19mini.fasta reference sequence dictionary. Missing sequence(s): [1] | ||
hg19mini_1renamed.fasta Compatible, the sequence dictionary in reads_data_source_test1_withmd5s_missingchr1.bam is a subset of the hg19mini_1renamed.fasta reference sequence dictionary. Missing sequence(s): [chr1] | ||
hg19mini_chr2snp.fasta Not compatible. Status: [DIFFER_IN_SEQUENCE, DIFFER_IN_SEQUENCES_PRESENT]. Run CompareReferences tool for more information on reference differences. | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE_SUBSET The sequence dictionary in reads_data_source_test1_withmd5s_missingchr1.bam is a subset of the hg19mini.fasta reference sequence dictionary. Missing sequence(s): [1] | ||
hg19mini_1renamed.fasta COMPATIBLE_SUBSET The sequence dictionary in reads_data_source_test1_withmd5s_missingchr1.bam is a subset of the hg19mini_1renamed.fasta reference sequence dictionary. Missing sequence(s): [chr1] | ||
hg19mini_missingchr1.fasta COMPATIBLE The sequence dictionaries exactly match | ||
hg19mini_chr2snp.fasta NOT_COMPATIBLE Status: [DIFFER_IN_SEQUENCE, DIFFER_IN_SEQUENCES_PRESENT]. Run CompareReferences tool for more information on reference differences. |
8 changes: 4 additions & 4 deletions
8
...ceCompatibility/expected.testReferenceCompatibilityMultipleReferencesBAMWithoutMD5s.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
#Current Reference: reads_data_source_test1_withoutmd5s.bam | ||
Reference Compatibility | ||
hg19mini.fasta All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
hg19mini_1renamed.fasta Not compatible. Status: COMMON_SUBSET. Run CompareReferences tool for more information on reference differences. | ||
hg19mini_chr2snp.fasta All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
hg19mini_1renamed.fasta NOT_COMPATIBLE Status: COMMON_SUBSET. Run CompareReferences tool for more information on reference differences. | ||
hg19mini_chr2snp.fasta COMPATIBLE All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |
6 changes: 3 additions & 3 deletions
6
...eference/CheckReferenceCompatibility/expected.testReferenceCompatibilityVCFWithMD5s.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: example_variants_withSequenceDict.vcf | ||
Reference Compatibility | ||
hg19mini.fasta All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
#Current Reference: example_variants_withSequenceDict_withmd5.vcf | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |
4 changes: 2 additions & 2 deletions
4
...CheckReferenceCompatibility/expected.testReferenceCompatibilityVCFWithoutMD5s_match.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: example_variants_withSequenceDict_withoutmd5s.vcf | ||
Reference Compatibility | ||
hg19mini.fasta All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |
4 changes: 2 additions & 2 deletions
4
...erenceCompatibility/expected.testReferenceCompatibilityVCFWithoutMD5s_notcompatible.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: example_variants_withSequenceDict_withoutmd5s.vcf | ||
Reference Compatibility | ||
hg19mini_missingchr3.fasta Not compatible. Status: COMMON_SUBSET. Run CompareReferences tool for more information on reference differences. | ||
Reference Compatibility Summary | ||
hg19mini_missingchr3.fasta NOT_COMPATIBLE Status: COMMON_SUBSET. Run CompareReferences tool for more information on reference differences. |
4 changes: 2 additions & 2 deletions
4
...heckReferenceCompatibility/expected.testReferenceCompatibilityVCFWithoutMD5s_subset.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#Current Reference: example_variants_withSequenceDict_withoutmd5s_missingchr1.vcf | ||
Reference Compatibility | ||
hg19mini.fasta All sequence names and lengths present in the sequence dictionaries match, but example_variants_withSequenceDict_withoutmd5s_missingchr1.vcf is a subset of hg19mini.fasta. Missing sequence(s): [1]. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. | ||
Reference Compatibility Summary | ||
hg19mini.fasta COMPATIBLE_SUBSET All sequence names and lengths present in the sequence dictionaries match, but example_variants_withSequenceDict_withoutmd5s_missingchr1.vcf is a subset of hg19mini.fasta. Missing sequence(s): [1]. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |
3 changes: 3 additions & 0 deletions
3
...e/CheckReferenceCompatibility/expected.testReferenceCompatibilityWithoutMD5Mismatch.table
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#Current Reference: reads_data_source_test1_withoutmd5s.bam | ||
Reference Compatibility Summary | ||
hg19mini_chr2snp.fasta COMPATIBLE All sequence names and lengths match in the sequence dictionaries. Since the MD5s are lacking, we can't confirm there aren't mismatching bases in the references. |