Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GATK to 4.6.0.0 in sv_pipeline_docker #719

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

mwalker174
Copy link
Collaborator

Bumps the version of GATK to 4.6.0.0 in sv_pipeline_docker. Note this is not the same as gatk_docker, as gatk is needed in some tasks that use GATK-SV code (e.g. svtk) and so it is built into the sv_base_docker image.

This addresses #81, but also the current commit has rotted with a dependency error, preventing new builds of sv_base_docker.

Note that the newer version of PrintSVEvidence produces an index file with 0-based indexing. This required changing/moving some tabix commands in the WDLs for consistency and to avoid wastefully regenerating the index. The 0-based indexing also caused problems with the sr-count call in GenotypeBatch, since the queries were off by 1 and this is the only place where tabix-based evidence queries require single-base precision.

Tested GenotypeBatch against v0.28.1-beta with the "bwa-melt" test cohort. Discrepancies in the output were minor and could be explained by recent PRs (e.g. #618). Also tested GatherBatchEvidence, GenerateBatchMetrics, ResolveComplexVariants, and GenotypeComplexVariants which passed sanity checks.

Typo

Fix PrintSVEvidence calls in WDLs

Fix 0-based indexing
Copy link
Collaborator

@epiercehoffman epiercehoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for unraveling this puzzle! As we discussed offline, it seems that a better long-term solution would be to ensure the index matches the evidence files, but this makes sense as an interim solution to allow the docker to be built with the new GATK version.

@mwalker174 mwalker174 mentioned this pull request Aug 27, 2024
@mwalker174 mwalker174 merged commit 6b27c39 into main Aug 27, 2024
9 checks passed
@mwalker174 mwalker174 deleted the mw_sv_pipeline_gatk branch August 27, 2024 19:47
@mwalker174 mwalker174 mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants