Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update melt docker image to current latest build. #592

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Aug 29, 2023

Given the license requirements of MELT, this image is not built and pushed to container registries using the GitHub actions. Hence, the latest builds of this image should be manually kept in synch between GCR and ACR. The image currently referenced for ACR is an older build than the image on GCR, and it does not include samtools. This PR updates the Docker image tag of MELT on ACR to the current latest tag on GCR.

Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like we forgot this in #468.

@VJalili
Copy link
Member Author

VJalili commented Aug 30, 2023

Thanks @mwalker174!

@VJalili VJalili merged commit 98ec699 into broadinstitute:main Aug 30, 2023
1 check passed
@VJalili VJalili deleted the melt-docker branch August 30, 2023 23:52
mwalker174 pushed a commit that referenced this pull request Aug 31, 2023
Add scramble dockerfile and update wdl

Create /app dir

Add docker Rscript test

Delete backslash

Update scramble docker

Bump Part1 memory to 3gb

Add cores option to scramble R script

Fix wdls

Add bcftools to docker

Update docker; 15 cores

cores -> threads

Update scramble repo commit

Fix dockerfile

Update scramble docker

Try 2 cores in Part1

Update runtimes

Update ubuntu, htslib, bcftools versions

Add wget

wget install

Move wget install

install just bcftools and htslib

Clean up bcftools source

Delete backslash

Update docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants