-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WX-1629] Add metadata value type tests #7433
Merged
Changes from 25 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
e60257d
[WX-1629] Add metadata value type tests
rsaperst 9b57ed5
Updated print
rsaperst a3266a5
Changed print to log
rsaperst ec872ad
Add additional centaur test and unit test
rsaperst 6b80c83
Add extra key to sanitize
rsaperst 724c363
Test that true != "true" in Centaur
rsaperst bd434e2
Added additional unit tests.
rsaperst b177495
Modify Centaur so that "true" != true
rsaperst f0f07c5
scalafmt
rsaperst 5c5c627
Make new test suite to run only metadata tests (temporary)
rsaperst a562b86
Modify testCentaurLocal.sh to only run metadata tests (temporary)
rsaperst 8e6899a
Slight modification to test suite
rsaperst 57075c3
Add additional printing
rsaperst 1be792d
Added more logging
rsaperst 0ade3ea
More logging
rsaperst 1539221
Modified Centaur to make comparisons taking data type into account
rsaperst 38b0a42
Merge branch 'develop' into wx1629
rsaperst 81f5f80
scalafmt
rsaperst 77fe961
Reverted yml change
rsaperst 97630aa
Reverted extraneous change
rsaperst 6f340e3
Fixed most failing tests
rsaperst 697d926
Parse lists from .test files
rsaperst b783831
Fixed remaining failing tests
rsaperst 645e4c7
Merge branch 'develop' into wx1629
rsaperst 76a9f1f
Remove extraneous log
rsaperst 6542a5d
Fixed last failing test
rsaperst f45d300
Review comments
rsaperst 08d7d8d
Revert whitespace change
rsaperst 6c32f1a
Test to see if this resolves timeout errors
rsaperst 8675777
Reverted test
rsaperst 1f3adb1
Added SSH step to integration tests
rsaperst 9f10bd1
Don't run lots_of_inputs on Papi
rsaperst 9b72152
Fix failing test
rsaperst f0329b9
Modify Papi config and re-enable lots_of_inputs test
rsaperst 1e589e8
Test lots_of_inputs instead of lots_of_inputs_papiv2
rsaperst 06e4850
Switch from if statements to pattern matching
rsaperst dd5872a
Switch to lots_of_inputs instead of lots_of_inputs_papiv2 on Horicrom…
rsaperst 32810b0
Cleanup
rsaperst 3ed63d2
Review fixes
rsaperst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,5 +13,5 @@ metadata { | |
status: Succeeded | ||
"outputs.draft3_infer_version.j": 660 | ||
"actualWorkflowLanguage": WDL | ||
"actualWorkflowLanguageVersion": 1.0 | ||
"actualWorkflowLanguageVersion": "1.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice one 😂 |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
centaur/src/main/resources/standardTestCases/metadata_type_validation.test
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: metadata_type_validation | ||
testFormat: workflowsuccess | ||
|
||
files { | ||
workflow: metadata_type_validation/metadata_type_validation.wdl | ||
} | ||
|
||
metadata { | ||
workflowName: metadata_type_validation | ||
status: Succeeded | ||
"outputs.metadata_type_validation.validate_string.string_output": "hello world" | ||
"outputs.metadata_type_validation.validate_int.int_output": 5 | ||
"outputs.metadata_type_validation.validate_boolean.boolean_output": "true" | ||
"outputs.metadata_type_validation.validate_float.float_output": 5.5 | ||
} |
60 changes: 60 additions & 0 deletions
60
...rc/main/resources/standardTestCases/metadata_type_validation/metadata_type_validation.wdl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
task validate_string { | ||
command { | ||
exit 0 | ||
} | ||
output { | ||
String string_output = "hello world" | ||
} | ||
runtime { | ||
docker: "ubuntu:latest" | ||
} | ||
} | ||
|
||
task validate_int { | ||
command { | ||
exit 0 | ||
} | ||
output { | ||
Int int_output = 5 | ||
} | ||
runtime { | ||
docker: "ubuntu:latest" | ||
} | ||
} | ||
|
||
task validate_boolean { | ||
command { | ||
exit 0 | ||
} | ||
output { | ||
Boolean boolean_output = true | ||
} | ||
runtime { | ||
docker: "ubuntu:latest" | ||
} | ||
} | ||
|
||
task validate_float { | ||
command { | ||
exit 0 | ||
} | ||
output { | ||
Float float_output = 5.5 | ||
} | ||
runtime { | ||
docker: "ubuntu:latest" | ||
} | ||
} | ||
|
||
workflow metadata_type_validation { | ||
call validate_string | ||
call validate_int | ||
call validate_boolean | ||
call validate_float | ||
output { | ||
validate_string.string_output | ||
validate_int.int_output | ||
validate_boolean.boolean_output | ||
validate_float.float_output | ||
} | ||
} | ||
rsaperst marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super nice, I've definitely been annoyed in the past about having to craft just the right escape sequence for a test.