-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BT-710 Add configs for BlobPathBuilderFactory #6817
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b1ca0d8
BT-710 Add configs for BlobPathBuilderFactory
kraefrei 75c265a
Corrected test assertions
kraefrei 0c1da99
Use ficus and correct config variable paths
kraefrei c34078b
Try to fix instance configs
kraefrei 6789acf
Use singleton config for workspace-manager-url
kraefrei 717bfa5
Modify test to include new blob filesystem
kraefrei e57eca5
Update reference.conf variable naming
kraefrei f1bb4b0
Remove blob as supported filesystem
kraefrei 16bdb3a
Fix imports for brackets
kraefrei 3daa895
Remove new line in refernce.conf
kraefrei 5b90821
Clean up test
kraefrei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
filesystems/blob/src/test/scala/cromwell/filesystems/blob/BlobPathBuilderFactorySpec.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package cromwell.filesystems.blob | ||
|
||
import com.typesafe.config.ConfigFactory | ||
import org.scalatest.flatspec.AnyFlatSpec | ||
import org.scalatest.matchers.should.Matchers | ||
|
||
class BlobPathBuilderFactorySpec extends AnyFlatSpec with Matchers { | ||
|
||
it should "parse configs for a functioning factory" in { | ||
val endpoint = BlobPathBuilderSpec.buildEndpoint("coaexternalstorage") | ||
val store = "inputs" | ||
val sasToken = "{SAS TOKEN HERE}" | ||
val workspaceId = "mockWorkspaceId" | ||
val workspaceManagerURL = "https://test.ws.org" | ||
val instanceConfig = ConfigFactory.parseString( | ||
s""" | ||
|sas-token = "$sasToken" | ||
|store = "$store" | ||
|endpoint = "$endpoint" | ||
|workspace-id = "$workspaceId" | ||
""".stripMargin) | ||
val singletonConfig = ConfigFactory.parseString(s"""workspace-manager-url = "$workspaceManagerURL" """) | ||
val globalConfig = ConfigFactory.parseString("""""") | ||
val factory = BlobPathBuilderFactory(globalConfig, instanceConfig, new BlobFileSystemConfig(singletonConfig)) | ||
factory.container should equal(store) | ||
factory.endpoint should equal(endpoint) | ||
factory.sasToken should equal(sasToken) | ||
factory.workspaceId should equal(workspaceId) | ||
factory.workspaceManagerURL should equal(workspaceManagerURL) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not check in this storage account name.
It might be worth taking another look at this test as part of our conversations about overall testing strategy, but I think it's fine to merge for now.