Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type compatibility regression on empty arrays #4324

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Fix type compatibility regression on empty arrays #4324

merged 5 commits into from
Oct 30, 2018

Conversation

aednichols
Copy link
Collaborator

Closes #4318

rsasch
rsasch approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kshakir
kshakir approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@kshakir kshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a centaur test to keep this from regressing again, then looks good to go.

wom/src/main/scala/wom/types/WomType.scala Outdated Show resolved Hide resolved
@aednichols
Copy link
Collaborator Author

@kshakir would it change your mind about the Centaur test to know the cases in WomTypeSpec.scala successfully detect the issue at a unit level?

@kshakir
Copy link
Contributor

kshakir commented Oct 29, 2018

Sure, any regression test (centaur or unit) works. LGTM!

@aednichols aednichols merged commit fdc6fdf into develop Oct 30, 2018
@aednichols aednichols deleted the aen_4318 branch October 30, 2018 13:53
@aednichols aednichols mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshakir kshakir kshakir approved these changes

@rsasch rsasch rsasch approved these changes

Assignees
No one assigned
Labels
User Joy 😄 User Joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aednichols @kshakir @rsasch