Set TMPDIR and HOME as expected by CWL conformance tests. #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbills
approved these changes
Feb 1, 2018
| @@ -114,7 +114,7 @@ trait StandardAsyncExecutionActor extends AsyncBackendJobExecutionActor with Sta | |||
| lazy val scriptEpilogue = configurationDescriptor.backendConfig.as[Option[String]]("script-epilogue").getOrElse("sync") | |||
|
|
|||
| lazy val temporaryDirectory = configurationDescriptor.backendConfig | |||
| .as[Option[String]]("temporary-directory").getOrElse("""$(mktemp -d "$PWD"/tmp.XXXXXX)""") | |||
| .as[Option[String]]("temporary-directory").getOrElse(s"""$$(mkdir -p "${runtimeEnvironment.tempPath}" && echo "${runtimeEnvironment.tempPath}")""") | |||
There was a problem hiding this comment.
ToL is this still temporary?
There was a problem hiding this comment.
not sure I understand the question?
Horneth
approved these changes
Feb 1, 2018
mcovarr
force-pushed
the
mlc_runtime_outdir
branch
from
59c2ae6
to
a84019e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly the first in a series as I trace down two other classes of failures.