-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inference results for 01.04.24 #17
base: main
Are you sure you want to change the base?
Conversation
@bkotzen thanks although it looks like you have 01.05 in various places where i'd expect 01.04 |
ah yes @martinjankowiak that is because the time zone of the virtual machine i used was ahead. perhaps the easiest thing to do would just be to update the readme? I think that's the only thing that is inconsistent |
this does make me think - the metadata is actually from 2024-01-01 (that was the most recent date available on GISAID). maybe it would be worth specifying the GISAID date in the metadata file moving forward? |
have you note been using the date that corresponds to the last day of data included? being the date you ran the inference is irrelevant |
right, agreed; I have been using the date of inference but I also have a record of the last day of data included so I can just change the names of the directories and push those changes in a separate PR |
ok updating the dates in a future PR would be good. but what do you want to do this this PR? cuz as it stands the links the readme won't work |
Hey @martinjankowiak a few updates here.
|
And for the sake of record keeping, here are the changes: |
@bkotzen how sure about this are you? in particular the first run from august 2022, which i believe i did. i wrote the following in the readme:
yet you seem to want to rename 08.10.22? |
Ok, I've combed through the commit history and found the commits which I have made and those which you have made. I can revert the dates back to how you had them for your commits! |
I believe this is the history and dates: MARTIN 05-18 |
Hey @martinjankowiak I've also added BVAS results for this week |
here are more current results @martinjankowiak |
Typo in the commit name but folder name has the correct gisaid download date! |
Hey @martinjankowiak just checking in - is this still a good place to be putting updated BVAS results? |
hey @martinjankowiak here are new bvas results! Happy new year :)