Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic labeling for issues #2057

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Add automatic labeling for issues #2057

merged 5 commits into from
Oct 11, 2024

Conversation

Caellian
Copy link
Collaborator

@Caellian Caellian commented Oct 10, 2024

This PR:

  • replaces old labeler action with a different one that works on both PRs (as the previous one) and issues.
  • adds support for labeling of os related things.
  • adds regex checking for issue content to automatically label issues based on keywords in (mostly) titles and body.
    • because users include configs in issues, a lot of keywords can't be checked for in the issue body as too many labels would be detected (maybe in future)

The only thing I don't like is that it re-applies labels to all issues when a new one is created. I made it pick labels very conservatively, but it could be annoying in some cases.

Signed-off-by: Tin Švagelj <[email protected]>
The new one has a lot more functionality.

Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
@github-actions github-actions bot added the gh-actions suggest changing GitHub actions label Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 2ce654b
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/670765901bfaa30008bf2367

@Caellian
Copy link
Collaborator Author

I tested to ensure the old labeling behavior is the same and that new one works.

@Caellian Caellian requested a review from brndnmtthws October 10, 2024 05:13
@Caellian
Copy link
Collaborator Author

I wanted to move stale labeling into this as well, but the changed labeler doesn't support auto-closing stale issues.

Signed-off-by: Tin Švagelj <[email protected]>
@Caellian Caellian merged commit 184af03 into brndnmtthws:main Oct 11, 2024
39 checks passed
Caellian added a commit that referenced this pull request Oct 11, 2024
Caellian added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh-actions suggest changing GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants