Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on nightly is not possible due to not having the upstream
ahash
bug fix from tkaitchuck/aHash#183:On the current main branch, we have two
ahash
dependencies:The resolution of the bug was done in the version 0.8.7: https://github.com/tkaitchuck/aHash/releases/tag/0.8.7.
In order to build brioche on nightly, I did two things (separated in two commits):
ahash 0.7.7
dep by updating deno_ast to 0.28.0: https://github.com/denoland/deno_ast/releases/tag/0.28.0ahash 0.8.6
without updating anything else withcargo update ahash
With both changes, brioche can be built on the latest Rust nightly version 2024-07-08.