Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Support in CMS5 #184

Merged
merged 1 commit into from
Jan 12, 2023
Merged

PHP Support in CMS5 #184

merged 1 commit into from
Jan 12, 2023

Conversation

sabina-talipova
Copy link
Collaborator

@sabina-talipova sabina-talipova changed the base branch from master to 3 December 8, 2022 03:07
@sabina-talipova sabina-talipova mentioned this pull request Dec 8, 2022
Closed
3 tasks
@sabina-talipova sabina-talipova changed the title Pulls/3/upgrade cms5 PHP Support in CMS5 Dec 8, 2022
emteknetnz
emteknetnz requested changes Dec 18, 2022
View reviewed changes
Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing unit tests

@sabina-talipova sabina-talipova force-pushed the pulls/3/upgrade-cms5 branch 6 times, most recently from bc9da4d to 9d81439 Compare December 20, 2022 01:00
@sabina-talipova
Copy link
Collaborator Author

Tests passed

@sabina-talipova sabina-talipova mentioned this pull request Dec 21, 2022
Merged
emteknetnz
emteknetnz requested changes Dec 21, 2022
View reviewed changes
tests/Util/ApiLoaderTest.php Outdated Show resolved Hide resolved
emteknetnz
emteknetnz previously requested changes Dec 21, 2022
View reviewed changes
src/Util/ApiLoader.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/3/upgrade-cms5 branch 2 times, most recently from 4aa1d74 to 059b153 Compare December 22, 2022 01:28
@sabina-talipova sabina-talipova force-pushed the pulls/3/upgrade-cms5 branch 3 times, most recently from 6f2a5d0 to f0d7d3a Compare January 11, 2023 21:55
@maxime-rainville maxime-rainville dismissed emteknetnz’s stale review January 12, 2023 04:32

Feedback has been addressed

@maxime-rainville maxime-rainville merged commit ea1c265 into bringyourownideas:3 Jan 12, 2023
@maxime-rainville maxime-rainville deleted the pulls/3/upgrade-cms5 branch January 12, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz left review comments

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabina-talipova @maxime-rainville @emteknetnz