API phpunit 9 support #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
f062977 to
907b3e3
Compare
maxime-rainville
requested changes
Nov 8, 2021
.travis.yml
Outdated
| after_success: | ||
| - if [[ $PHPUNIT_COVERAGE_TEST ]]; then bash <(curl -s https://codecov.io/bash) -f coverage.xml; fi | ||
| import: | ||
| - silverstripe/silverstripe-travis-shared:config/provision/standard-jobs-range.yml |
There was a problem hiding this comment.
What's the point of using the travis CI build if travis is not running?
There was a problem hiding this comment.
Not alot :-) Removed
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
907b3e3 to
54d2313
Compare
|
@maxime-rainville failing unit test requires tagging a new minor of queuedjobs which requires unreleased framework ^4.10 - we should probably just merge this as is |
|
I don't think tagging a new minor would be terrible ... composer wouldn't be incline to install it if it's set to prefer stable. That's another example why I think not getting the manifest to ignore tests is not a viable choice. I'll go through the other PRs and come back to this one later on |
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
54d2313 to
d6fb30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10019