Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Settings Menu #3044

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Fixed the Settings Menu #3044

merged 7 commits into from
Apr 10, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Apr 9, 2024

Just a few files change. 🤣

I redid the settings modal, and updated all form elements in the app. Hopefully for the last time.

And the bug about the brimcap file is fixed.

CleanShot 2024-04-09 at 16 07 50@2x

CleanShot 2024-04-09 at 16 08 16@2x

Fixes #2949

@philrz

This comment was marked as resolved.

@philrz

This comment was marked as resolved.

@philrz
Copy link
Contributor

philrz commented Apr 10, 2024

@jameskerr and I had an offline discussion about my first impressions upon reviewing the new design in this PR. At first I was thrown by the lack of an explicit Save button like we used to have in the old Settings menu. The one thing this loses us is the ability to start making a change but then hit Esc or click Cancel to back out and leave the prior setting intact. However, after a quick review of some modern tools like Slack and VSCode, I could see that the approach used here where changes are effectively committed immediately is now more in vogue. I've quickly adjusted to the new paradigm and I'm optimistic our users will as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using "Brimcap YAML Config File" causes stack trace and breaks Settings
2 participants