Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to react 17 #1169

Closed
wants to merge 1 commit into from
Closed

upgrade to react 17 #1169

wants to merge 1 commit into from

Conversation

mason-fish
Copy link
Contributor

As noted in their release notes, there are no new features and very minimal breaking changes in this major release bump. The only thing I saw that we can change is removing the event persistence, which is no longer necessary. All manual and automated testing has passed locally.

signed-off-by: Mason Fish [email protected]

Signed-off-by: Mason Fish <[email protected]>
@mason-fish mason-fish requested review from a team and removed request for a team October 27, 2020 18:42
@jameskerr
Copy link
Member

It looks like the failure is from our enzyme react adapter. Maybe this works? https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17

@mason-fish
Copy link
Contributor Author

mason-fish commented Oct 27, 2020

update: while my personal testing and integrations pass, the unit testing is blocked on the enzyme lib's react adapter update (enzymejs/enzyme#2429 (comment)) I'll close for now, and reopen when that changes.

@mason-fish mason-fish closed this Oct 27, 2020
@mason-fish
Copy link
Contributor Author

@jameskerr I thought it would be better to wait for the official adapter since we aren't desperate to upgrade, wdyt?

@jameskerr
Copy link
Member

Sounds good to me!

@nwt nwt deleted the upgrade-react-17 branch April 1, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants