Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't leave insert mode #27

Closed
katlyn-edwards opened this issue Jul 19, 2019 · 4 comments
Closed

Can't leave insert mode #27

katlyn-edwards opened this issue Jul 19, 2019 · 4 comments

Comments

@katlyn-edwards
Copy link
Contributor

See #18

ESC is getting default-prevented from Monaco itself, and the library seems to be respecting that.

Maybe we can add a flag/property to the event to disable defaultPrevented from stopping it?

@katlyn-edwards
Copy link
Contributor Author

I ended updoing

        Object.defineProperty(
            e, 'defaultPrevented', {writable: false, value: false});

@brijeshb42
Copy link
Owner

Introducing a flag seems the best way right know. At work, we are using monaco v0.14.x so we don't have this problem right now. But yeah, newer versions will need this. It would have been best if monaco also included a version number in their api like react does.

@ianberdin
Copy link

What we should with newer version?
Do we have a solution?

@brijeshb42
Copy link
Owner

Fixed with #28

Note that you won't be able to handle ESC key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants