-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rapidfuzz
optional on sys_platform=emscripten
#179
Make rapidfuzz
optional on sys_platform=emscripten
#179
Conversation
...hmmm, that is annoying. I just added the same condition to my testing package - and the build ran fine there. |
...must have been the semicolon. |
@cmutel, not sure what black magic I need to re-run the checks on this PR. Otherwise ready for review. |
I think the review comes before CI, though I don't really understand that... Don't we also need to shortcircuit the calls which use rapidfuzz, or am I missing other commits or PRs? It seems like this would just lead to an import error. |
Since you answer to my question
Was "Yup", I assumed all those short-circuits would be in place. Maybe I should have had a look at the link you provided... |
OK, CI isn't running because the code didn't change, only the build config. |
Commit that introduced Since the |
Sure, that would work; the API might be slightly different but we can control it in the file we included (i.e. make it fit |
...ok, I think it's all ready - you're already falling back to the string_distance.py file anyway! |
...until:
rapidfuzz
to emscipten-forge and Pyodide brightway-live#59is ready, this would fix:
bw2io
,bw2data
,bw2calc
, WASM Compatibility Issues (2024) brightway-live#57