Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo Path Broken (#2) #106

Closed
1 of 2 tasks
michaelweinold opened this issue Jul 27, 2023 · 5 comments
Closed
1 of 2 tasks

Logo Path Broken (#2) #106

michaelweinold opened this issue Jul 27, 2023 · 5 comments

Comments

@michaelweinold
Copy link
Contributor

michaelweinold commented Jul 27, 2023

Similar (but with a different root cause) to this issue from 2022:

the logo is rendered correctly on readthedocs, but not in the local build. How that is possible, I don't know - they use the same environment.yml (with pinned versions of the theme and Sphinx).

The local build:

WARNING: Path to dark image logo does not exist: logo/BW_all_white_transparent_landscape.svg
build succeeded, 239 warnings.
[W 230626 21:18:29 web:2344] 404 GET /_static/BW_all_black_transparent_landscape.svg (127.0.0.1) 0.43ms
Screenshot 2023-06-26 at 21 25 47

The current workaround is to place a copy of the logo files into the _static directory, not in a subdirectory like _static/logo. As soon as this has been fixed by the pydata-sphinx-theme team:

we can remove the copies.

@tngTUDOR
Copy link
Contributor

can't reproduce when building with:

sphinx-autobuild source _build/html -a -j auto --open-browser

or with

sphinx-build source _build/html -b singlehtml -a

either

Are you removing the _build folder after a couple of builts?

@michaelweinold
Copy link
Contributor Author

...could have been resolved with my upgrade of Sphinx:

I'll check again.

@michaelweinold
Copy link
Contributor Author

If you start with:

  1. A clean (or missing) _build folder
  2. Without the logos which I copied to the top level of the _static folder (eg./brightway-documentation/source/_static/BW_all_black_transparent_landscape.svg) as a temporary workaround:

The current workaround is to place a copy of the logo files into the _static directory, not in a subdirectory like _static/logo. As soon as this has been fixed by the pydata-sphinx-theme team:

then the issue persists.

@alyabolowich
Copy link

alyabolowich commented Sep 16, 2023

Did a fresh git clone and build following the instructions in the readme and the logo appears.

image

@michaelweinold
Copy link
Contributor Author

Neither of the underlying issues pydata/pydata-sphinx-theme#1385 and pydata/pydata-sphinx-theme#1328 were fixed in the latest release of the pydata-sphinx-theme. The current workaround remains to retain a copy of all files in source/_static/logo also in source/_static. Since I implemented this workaround, you are seeing the logo (as you reported).

@michaelweinold michaelweinold pinned this issue May 27, 2024
michaelweinold added a commit that referenced this issue Jun 18, 2024
michaelweinold added a commit that referenced this issue Jun 18, 2024
@michaelweinold michaelweinold unpinned this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants