Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rad 197 upgrade sal 4 j to java 21 #5

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

adam-kimpton
Copy link
Contributor

No description provided.

Copy link
Contributor

@stephen-rouxel stephen-rouxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made one comment regarding branch use for the java workflow, otherwise it should be ready to merge

@@ -3,11 +3,13 @@ on: [push, pull_request]

jobs:
call-java-workflow:
uses: brightsparklabs/github-actions/.github/workflows/java.yml@master
uses: brightsparklabs/github-actions/.github/workflows/java.yml@develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-kimpton What is the benefit of using develop henceforth? Is it simply so we don't have to make a PR to master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes I had made to the github-actions repo are now merged into the master branch, I have updated this line to once again reference the master branch.

@stephen-rouxel stephen-rouxel merged commit 99efd8a into develop Oct 4, 2024
6 checks passed
@stephen-rouxel stephen-rouxel deleted the feature/RAD-197-upgrade-sal-4-j-to-java-21 branch October 4, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants