-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strict lint voilations #67
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.4.0-STRICT #67 +/- ##
================================================
Coverage ? 81.43%
================================================
Files ? 50
Lines ? 1056
Branches ? 0
================================================
Hits ? 860
Misses ? 196
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@leogdion The fixes here are just the simple fixes, for more fixes like body length, missing docs, I am working on different branch so we don't mess with this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Just a few changes and then let's chat about next steps.
* Support Option Link for RSS (#65) * updating workflow * adding more workflows * fixup! adding more workflows * Update dependabot.yml * working on linting * [skip ci] fixing linting * fix: errors with tests * fix: possible lint issues * fix: SiteCollectionDirectory.Instance to be internal than private * mint-upgrade: periphery from 2.12.3 to 2.18.0 * resolve PR conversations * redo: post.id back to post.ID * fix: post.ID and make the property called ID * Fix strict lint voilations (#67) * fixup! fix: post.ID and make the property called ID * Any other lint violations that are not 'Missing Docs Violation' (#68) * lint-fixes: any voilation that is not 'Missing Docs Violation' * fixup! Merge branch 'v0.4.0-STRICT-changes' into v0.4.0-STRICT-others --------- Co-authored-by: leogdion <[email protected]> * Adding Documentation Comments --------- Co-authored-by: Ahmed Shendy <[email protected]>
No description provided.