V0.3.8 #61
Merged
V0.3.8 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Issue #26
* test: invalid expansionState * add: new Podcast of Phase 1 & Phase 2 * update: integrate podcast types into RSSChannel & RSSItem * resolve: review threads * update: PodcastLocation value to name * update: PodcastPerson role as enum with supported values of Transistor.fm * resolve: review comments * fix: all arrays should not be optional * update: make WordPressPost.role insensitive and add unknown * refactoring Role * fix: Recursion happening Role.init?(rawValue: String) and Role.init(knownRole: KnownRole) * test: podcast elements of RSSChannel & RSSItem * fix: some lint-issues * test: UTF8EncodedURL, XMLStringInt * update: make geo,osm of PodcastLocation as custom types, update: swiftdoc for podcast elements * update: make all podcast elements as Equatable (except PodcastEpisode) * add: tests to podcast elements to increase testcov for previous commit * update: PodcastChapters & PodcastTranscript with custom decoding for caseInsensitive enums * update: move custom decoding of geo & osm into their own types * update: osm to osmQuery, and remove all xml elements * update: make osmQuery, geo as optional * resolve: review comments * fix: use default decoding for PodcastPerson+Role, PodcastTranscript+MimeType, PodcastChapters+MimeType --------- Co-authored-by: Leo Dion <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 80.86% 83.12% +2.25%
==========================================
Files 39 50 +11
Lines 805 1025 +220
==========================================
+ Hits 651 852 +201
- Misses 154 173 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.